Update Blender export flags for 3.6. #81194

rcorre · 2023-08-31T12:50:44Z

Blender 3.6 imports fail with:

TypeError: Converting py args to operator properties: : keyword "export_nla_strips" unrecognized

The export_nla_strips flag was removed and replaced with export_animation_mode.
In 3.6.0-3.6.21, this option does not exist at all and causes the failure above.
In 3.6.22, this option was re-added, but does nothing.
See https://projects.blender.org/blender/blender-addons/commit/96a73cb664bca687b7ea2e464c4d08f8082d5012.

We now need to check the blender version to determine what flags to use.
This adds an additional shell command before every import.
We might consider caching the version, but we'd have to invalidate the cache if the blender version or path changes.

As an aside, the "group animations" setting in Godot does the opposite of what I'd expect.
When group_tracks=true, each animation is exported individually.
When group_tracks=false, all animations are exported as a single track.
This seems backwards, but I've kept the 3.6 behavior consistent with 3.5.

From https://docs.blender.org/api/3.6/bpy.ops.export_scene.html:

ACTIONS Actions – Export actions (actives and on NLA tracks) as separate animations.
ACTIVE_ACTIONS Active actions merged – All the currently assigned actions become one glTF animation.

akien-mga · 2023-08-31T12:57:43Z

We now need to check the blender version to determine what flags to use.
This adds an additional shell command before every import.
We might consider caching the version, but we'd have to invalidate the cache if the blender version or path changes.

I think it's worth caching, only for a given Godot session (so in a member variable, not saved to disk).

filesystem/import/blender/blender3_path is already set to request a restart when changed, and if users change the Blender version without changing that path (e.g. relying on /usr/bin/blender and their distro upgrades), I think it's fine if we don't catch this for one session (the workaround would be to restart the editor after seeing that import don't work).

modules/gltf/editor/editor_scene_importer_blend.cpp

rcorre · 2023-08-31T14:43:35Z

I added caching and fixed the version checks. Thanks!

modules/gltf/editor/editor_scene_importer_blend.cpp

rcorre · 2023-09-17T11:54:11Z

BTW, is anyone able to comment on this?

As an aside, the "group animations" setting in Godot does the opposite of what I'd expect.
When group_tracks=true, each animation is exported individually.
When group_tracks=false, all animations are exported as a single track.
This seems backwards, but I've kept the 3.6 behavior consistent with 3.5.

Is this the expected behavior of group_tracks?

fire · 2023-09-17T15:21:58Z

When group_tracks=true, each animation is exported individually.
When group_tracks=false, all animations are exported as a single track.

That sounds backwards, it's probably a bug and we need need to retire / rename the setting as a new variable with a transfer function.

rcorre · 2023-09-24T15:42:47Z

That sounds backwards, it's probably a bug and we need need to retire / rename the setting as a new variable with a transfer function.

I'll do that in a separate PR to avoid complicating this one.

fire

Looks good to me. We discussed in this thread what to do with group_tracks and there's a related pr on upwards compatibility that we're superseding.

Since this is a widely used feature we'll get better feedback on any edge cases with testing.

modules/gltf/editor/editor_scene_importer_blend.cpp

fire · 2023-09-25T16:53:26Z

modules/gltf/editor/editor_scene_importer_blend.cpp

+
+#if defined(MACOS_ENABLED)
+	if (!FileAccess::exists(path)) {
+		path = path.path_join("Blender");


This is a bit odd. I didn't want to delay the merge, but isn't the mac case-insensitive?

APFS is case sensitive by default, but can be configured as case-sensitive: https://support.apple.com/guide/disk-utility/file-system-formats-dsku19ed921c/mac

Does this work though?

This code tests p_path + "/blender", and then if it fails it tests p_path + "/blender/Blender". That seems a bit arbitrary and not just a matter of case sensitivity?

Yeah, that seems wrong. I can change it, but I don't have a mac to test on (again, this is moved code, not changed code)

I've changed it, as it did seem most likely wrong, but don't have a mac to test on.

Fixes godotengine#76338. Blender 3.6 imports fail with: ``` TypeError: Converting py args to operator properties: : keyword "export_nla_strips" unrecognized ``` The `export_nla_strips` flag was removed and replaced with `export_animation_mode`. In 3.6.0-3.6.21, this option does not exist at all and causes the failure above. In 3.6.22, this option was re-added, but does nothing. See https://projects.blender.org/blender/blender-addons/commit/96a73cb664bca687b7ea2e464c4d08f8082d5012. We now need to check the blender version to determine what flags to use. This adds an additional shell command before every import. We might consider caching the version, but we'd have to invalidate the cache if the blender version or path changes. As an aside, the "group animations" setting in Godot does the opposite of what I'd expect. When `group_tracks=true`, each animation is exported individually. When `group_tracks=false`, all animations are exported as a single track. This seems backwards, but I've kept the 3.6 behavior consistent with 3.5. From https://docs.blender.org/api/3.6/bpy.ops.export_scene.html: > ACTIONS Actions – Export actions (actives and on NLA tracks) as separate animations. > ACTIVE_ACTIONS Active actions merged – All the currently assigned actions become one glTF animation. Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>

akien-mga · 2023-10-02T11:21:13Z

Thanks!

YuriSizov · 2023-10-24T17:57:04Z

Cherry-picked for 4.1.3.

Uradamus · 2023-12-04T08:37:50Z

The Blender 4 tickets may have been closed prematurely. Just launched Godot 4.2 and after I dropped the Cyclops add-on into a new project I got a pop up asking me to provide a valid path to a Blender 3 install, which was pre-filled with the path to my Steam install of Blender which updated to 4.0 not long ago. I had to hunt down an old back-up version of Blender 3.x to point it at instead to get the add-on to import (since it comes with a bunch of .blend files). I'm also using Godot from Steam if that matters any.

EDIT: I spoke too soon; the Blender 3 version I pointed at didn't end up working, probably too old now (Blender 3.0). The console was flooded with errors about not being able to open the files. And the import pop-up kept flashing over and over again in an endless loop, had to kill Godot. Was a real mess.

EDIT2: Grabbed the latest 3.6.5 LTS build from the Blender website and replaced the 3.0 install with that and Godot is back to complaining about wanting a valid path with the error: "Unexpected --version output from Blender binary at: /path/to/blender"

YuriSizov · 2023-12-04T09:40:51Z

@Uradamus As mentioned in the closed proposal, please open an issue in this repository if something is not working correctly. Comments on merged PRs are easy to miss and hard to track.

If you think the proposal itself still has merits and should be reopened, you can leave a comment about it on the proposal itself (closed proposal is "resolved" but the discussion can still continue and it can be reopened).

Uradamus · 2023-12-04T09:56:25Z

I'm at the point where I will probably end up dropping Godot, I'm so tired of all the troubles with the import pipeline for 3D stuff. So fix it, don't fix it, doesn't matter to me anymore. I've wasted way to much time on this already. Focusing so heavily on GLTF was a mistake, this is just another symptom of that.

The other big area where GLTF has been totally broken has been with shared animation libraries meant to be used by several models. I spent weeks trying to get it working to no avail and now these troubles with getting Blender working with it. I only bring it up in case no one else ran into it, but I'm wiping my hands of this mess for now. Maybe I'll revisit in a year or two to see if anythings been improved or at least better documented if nothing else. I'm just far too fed up to put any more energy into this right now (nothing against you or your suggestions, this is just frustration with all the time wasted with nothing to show for it and continuing to hit walls over stuff that should have been sorted already like this.)

rcorre requested a review from a team as a code owner August 31, 2023 12:50

akien-mga added bug topic:import cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 31, 2023

akien-mga added this to the 4.2 milestone Aug 31, 2023

AThousandShips reviewed Aug 31, 2023

View reviewed changes

modules/gltf/editor/editor_scene_importer_blend.cpp Outdated Show resolved Hide resolved

AThousandShips reviewed Aug 31, 2023

View reviewed changes

modules/gltf/editor/editor_scene_importer_blend.cpp Outdated Show resolved Hide resolved

rcorre force-pushed the blend-import-76338 branch from 0d1a398 to a7854da Compare August 31, 2023 14:43

rcorre requested a review from AThousandShips August 31, 2023 14:43

fire reviewed Aug 31, 2023

View reviewed changes

modules/gltf/editor/editor_scene_importer_blend.cpp Show resolved Hide resolved

modules/gltf/editor/editor_scene_importer_blend.cpp Outdated Show resolved Hide resolved

rcorre force-pushed the blend-import-76338 branch from a7854da to 76bde75 Compare September 2, 2023 21:57

AThousandShips reviewed Sep 3, 2023

View reviewed changes

modules/gltf/editor/editor_scene_importer_blend.cpp Outdated Show resolved Hide resolved

rcorre force-pushed the blend-import-76338 branch from 71616ab to b50f344 Compare September 3, 2023 22:35

rcorre requested review from fire and AThousandShips September 3, 2023 22:35

fire requested review from a team September 17, 2023 15:19

Calinou mentioned this pull request Sep 23, 2023

Blender importer: allow Blender 4 executables #82211

Closed

rcorre mentioned this pull request Sep 24, 2023

Failure to import .blend with Blender package from Arch Linux #76338

Closed

fire approved these changes Sep 25, 2023

View reviewed changes

AThousandShips reviewed Sep 25, 2023

View reviewed changes

modules/gltf/editor/editor_scene_importer_blend.cpp Outdated Show resolved Hide resolved

fire reviewed Sep 25, 2023

View reviewed changes

rcorre force-pushed the blend-import-76338 branch from 6ada2af to 01e6338 Compare September 26, 2023 11:08

rcorre requested review from fire and AThousandShips September 26, 2023 11:08

rcorre force-pushed the blend-import-76338 branch from 01e6338 to 7e64c6c Compare September 30, 2023 15:32

rcorre requested a review from akien-mga September 30, 2023 15:33

akien-mga approved these changes Oct 2, 2023

View reviewed changes

akien-mga merged commit 3cf1767 into godotengine:master Oct 2, 2023
15 checks passed

akien-mga changed the title ~~Update blender export flags for 3.6.~~ Update Blender export flags for 3.6. Oct 3, 2023

akien-mga mentioned this pull request Oct 6, 2023

Import .blend using Blender 4.0 #79124

Closed

rcorre deleted the blend-import-76338 branch October 22, 2023 18:07

YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023

Calinou mentioned this pull request Nov 15, 2023

Blender 4 Support godotengine/godot-proposals#8436

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Blender export flags for 3.6. #81194

Update Blender export flags for 3.6. #81194

rcorre commented Aug 31, 2023

akien-mga commented Aug 31, 2023

rcorre commented Aug 31, 2023

rcorre commented Sep 17, 2023

fire commented Sep 17, 2023

rcorre commented Sep 24, 2023

fire left a comment

fire Sep 25, 2023

rcorre Sep 26, 2023

akien-mga Sep 26, 2023 •

edited

Loading

rcorre Sep 30, 2023

rcorre Sep 30, 2023

akien-mga commented Oct 2, 2023

YuriSizov commented Oct 24, 2023

Uradamus commented Dec 4, 2023 •

edited

Loading

YuriSizov commented Dec 4, 2023

Uradamus commented Dec 4, 2023 •

edited

Loading

Update Blender export flags for 3.6. #81194

Update Blender export flags for 3.6. #81194

Conversation

rcorre commented Aug 31, 2023

akien-mga commented Aug 31, 2023

rcorre commented Aug 31, 2023

rcorre commented Sep 17, 2023

fire commented Sep 17, 2023

rcorre commented Sep 24, 2023

fire left a comment

Choose a reason for hiding this comment

fire Sep 25, 2023

Choose a reason for hiding this comment

rcorre Sep 26, 2023

Choose a reason for hiding this comment

akien-mga Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

rcorre Sep 30, 2023

Choose a reason for hiding this comment

rcorre Sep 30, 2023

Choose a reason for hiding this comment

akien-mga commented Oct 2, 2023

YuriSizov commented Oct 24, 2023

Uradamus commented Dec 4, 2023 • edited Loading

YuriSizov commented Dec 4, 2023

Uradamus commented Dec 4, 2023 • edited Loading

akien-mga Sep 26, 2023 •

edited

Loading

Uradamus commented Dec 4, 2023 •

edited

Loading

Uradamus commented Dec 4, 2023 •

edited

Loading